-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli/unstable): add promptSelect()
#6190
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6190 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 532 533 +1
Lines 40819 40870 +51
Branches 6111 6122 +11
=======================================
+ Hits 39416 39467 +51
- Misses 1360 1361 +1
+ Partials 43 42 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
I've added some tests but need help resolving the current errors. The tests ran successfully locally. I don't know, why they occur and how to fix them. |
I think you also need to stub |
cli/unstable_prompt_select_test.ts
Outdated
const encoder = new TextEncoder(); | ||
const decoder = new TextDecoder(); | ||
|
||
function spyFn<T, K extends keyof T>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why create original spy util here? What was wrong with spy
in @std/testing/mock
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spy
didn't work for that purpose, but @std/testing/mock
's stub()
did it 👍
Im really excited for this one! Its exactly what I've been looking for! <3 |
promptSelect()
promptSelect()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests seem nicely written. LGTM
Ref: #4678
Changes
Adds
promptSelect()
cli function.