Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: support go 1.23 #1160

Merged
merged 4 commits into from
Aug 16, 2024
Merged

chore: support go 1.23 #1160

merged 4 commits into from
Aug 16, 2024

Conversation

42atomys
Copy link
Contributor

Add support for go 1.23 as released https://go.dev/doc/go1.23

@42atomys 42atomys requested a review from a team as a code owner August 15, 2024 19:15
@42atomys
Copy link
Contributor Author

@microsoft-github-policy-service agree

@samruddhikhandale samruddhikhandale mentioned this pull request Aug 15, 2024
Open
5 tasks
samruddhikhandale
samruddhikhandale requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to contribute this change, appreciate it 🙌

src/go/README.md Outdated Show resolved Hide resolved
src/go/manifest.json Outdated Show resolved Hide resolved
src/go/manifest.json Outdated Show resolved Hide resolved
src/go/manifest.json Show resolved Hide resolved
@samruddhikhandale
Copy link
Member

Opened #1160 and #1162 for tracking this end-to-end.

@samruddhikhandale samruddhikhandale mentioned this pull request Aug 15, 2024
Open
5 tasks
@42atomys
Copy link
Contributor Author

Thanks for the reviews and issues 🙏 Changes applied ✔️

samruddhikhandale
samruddhikhandale approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good. Thanks!

We'd release this new image on Monday.

@samruddhikhandale samruddhikhandale merged commit b72835d into devcontainers:main Aug 16, 2024
2 checks passed
@yp05327 yp05327 mentioned this pull request Aug 19, 2024
Merged
@samruddhikhandale samruddhikhandale mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@42atomys @samruddhikhandale