perf: Optimize templates resource loading peformance #9090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR
Small perf optimization related to templates resource loading.
CreateTemplateResource()
call.ToArray()
beforeIResourceFileReader::Names
property is set.Because Names are enumerated multiple times.
HashSet<string>
for Names check. BecauseResourceFileReader::GetResourceStream
is called multiple times.For example. it is called about 443 times for
samples/seed
project.And Names contains 71/93 elements (For default/modern templates).