Expose SQLite VFS option in connection string #34864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arontsang
force-pushed
the
master
branch
2 times, most recently
from
db442e9
to
27747aa
Compare
|
@arontsang This needs to be updated to target |
arontsang
force-pushed
the
master
branch
2 times, most recently
from
0bd8307
to
cfd4ada
Compare
|
@cincuranet Updated |
cincuranet
reviewed
Nov 12, 2024
| @@ -55,10 +57,11 @@ private enum Keywords | |||
| private bool _recursiveTriggers; | |||
| private int _defaultTimeout = 30; | |||
| private bool _pooling = true; | |||
| private string? _vfs = string.Empty; | |||
There was a problem hiding this comment.
I think the default value should be null. Any reason for string.Empty?
| @@ -269,6 +285,9 @@ public override object? this[string keyword] | |||
| case Keywords.Pooling: | |||
| Pooling = Convert.ToBoolean(value, CultureInfo.InvariantCulture); | |||
| return; | |||
| case Keywords.Vfs: | |||
| Vfs = Convert.ToString(value, CultureInfo.InvariantCulture);; | |||
There was a problem hiding this comment.
nit: Two semicolons at the end.
| @@ -458,6 +477,9 @@ private void Reset(Keywords index) | |||
| case Keywords.Pooling: | |||
| _pooling = true; | |||
| return; | |||
| case Keywords.Vfs: | |||
| _vfs = string.Empty; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to expose the VFS option in the connection string.