Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] - Fix for Shell Section Visibility changes not reflected until Tab switch #26130

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[Windows] - Fix for Shell Section Visibility changes not reflected until Tab switch #26130

wants to merge 6 commits into from

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

Root Cause of the issue

  • The section items were not updated correctly when the items changed at runtime. The ItemsCollectionChanged event for the shell section was not handled on the Windows platform.

Description of Change

  • The ItemsCollectionChanged event has been implemented for the Windows platform. In this event, the section items are properly updated whenever the collection changes at runtime.

Issues Fixed

Fixes #25913

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
Shell-section-issue.mp4
Fix.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 26, 2024
@jsuarezruiz jsuarezruiz added area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/windows 🪟 labels Nov 26, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] - Top Tab Visibility Changes Not Reflected Until Tab Switch
2 participants
@Tamilarasan-Paranthaman @jsuarezruiz