Allow optimizing mask conversions on x64 as well #110195
Open
+149
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
tannergooding
force-pushed
the
msk-lcl-x64
branch
from
e9f236c
to
1cb24aa
Compare
tannergooding
force-pushed
the
msk-lcl-x64
branch
from
dea61f4
to
58e20f9
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just extends the mask conversion optimization to light-up on x64 as well. In order to achieve that it mostly just adds in the minor different handling for the conversion cost and ensuring the right operand is accessed.
It additionally adds support for one more important scenario, which is recognizing that
ConditionalSelectdespite taking a vector in IR has special support to be lowered/contained such that the mask can be consumed directly. -- The same is technically also possible for the various bitwise operations, but those are less important to handle initially.