Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CPM in Binary Tool #41884

Closed
wants to merge 1 commit into from
Closed

Conversation

ellahathaway
Copy link
Member

Fixes dotnet/source-build#4487

In order for the binary tool to use the versions of the packages specified in CustomPackageVersionsProps, we need to specify that we are using CPM.

Example build with change (internal Microsoft link)

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Jul 1, 2024
@ellahathaway ellahathaway marked this pull request as ready for review July 1, 2024 21:18
@ellahathaway ellahathaway requested review from a team as code owners July 1, 2024 21:18
@ellahathaway
Copy link
Member Author

Templating repo failed in the linked build, but it appears unrelated to the changes in this PR.

@ViktorHofer
Copy link
Member

Interesting. What changed that makes this now necessary?

@ellahathaway
Copy link
Member Author

ellahathaway commented Jul 2, 2024

Interesting. What changed that makes this now necessary?

From what I can tell, the change that brought in this error was an upgrade of the version of nuget that we're using: https://dev.azure.com/dnceng/internal/_git/dotnet-dotnet/commit/aa327a6db9bba39f54a57b1d4c04c6ab2dace340?path=/prereqs/git-info/nuget-client.props (internal link)

Otherwise, nothing changed with the tool itself or the scripts we use to configure it to suddenly cause this.

@ellahathaway
Copy link
Member Author

Timeout in CI - Seems like it's related to #40074

@ViktorHofer
Copy link
Member

I noticed that this isn't enough any only fixes the "Prepare for build" job. CPM in general got broken in dotnet/dotnet but is only observable in a stage2 build. I submitted #41895. This PR shouldn't be needed anymore.

@ellahathaway
Copy link
Member Author

I noticed that this isn't enough any only fixes the "Prepare for build" job. CPM in general got broken in dotnet/dotnet but is only observable in a stage2 build. I submitted #41895. This PR shouldn't be needed anymore.

Oh great, thanks Victor! I'll close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMR stage2 failed to find a stable package System.CommandLine
3 participants