Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dnceng/internal/dotnet-wpf-int #9263

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 19, 2024

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-wpf-int

  • Subscription: f8781171-8d89-4d6b-f62b-08d8e93a0c51
  • Build: 20240619.2
  • Date Produced: June 19, 2024 10:14:29 AM UTC
  • Commit: 05a90169210897f51f0550c0396ef44240bee390
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

…otnet-wpf-int build 20240619.2

Microsoft.DotNet.Wpf.DncEng
 From Version 9.0.0-preview.6.24314.2 -> To Version 9.0.0-preview.7.24319.2
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 19, 2024
@MichalStrehovsky
Copy link
Member

@ViktorHofer do you think we can drop the CoherentParentDependency attribute on the new System.Runtime.Serialization.Formatters package like Maestro suggests? It looks like WinForms doesn't actually use the package - the references in the WinForms repo seem to only come from tests.

I'm guessing #9264 is blocked on this now.

@ViktorHofer
Copy link
Member

The dependency is now already defined in winforms but we need the winforms dependency Update PR for that. So we are in a chicken egg situation right now.

I suggest to just merge this PR with the failing coherency check. I don't have permissions though.

@MichalStrehovsky
Copy link
Member

@dotnet/wpf-developers main is currently broken (see #9265 that is failing with the same issue as #9264). It seems to be because the CI machines picked up a new Visual Studio and there are some binaries in the build that were built with old Visual Studio.

The #9264 PR is on a critical path for the dotnet/sdk repo (dotnet/sdk#41616 (comment)). Could you help us unblock?

@dipeshmsft
Copy link
Member

dipeshmsft commented Jun 20, 2024

@ViktorHofer , so after merging this PR, we need to merge #9264 as well, and after that the issue will be resolved ?
Am I misunderstanding something here ?

From what I see, it looks like #9264 is dependent on this PR.

@ViktorHofer
Copy link
Member

That's the theory, yes.

@MichalStrehovsky
Copy link
Member

PRs against main are currently failing with:

LINK(0,0): error C1047: (NETCORE_ENGINEERING_TELEMETRY=Build) The object or library file 'D:\a\_work\1\s\.packages\runtime.win-x64.microsoft.dotnet.wpf.dnceng\9.0.0-preview.6.24314.2\runtimes\win-x64\native\bilinearspan.lib' was created by a different version of the compiler than other objects like 'D:\a\_work\1\s\artifacts\obj\wpfgfx\x64\Release\precomp.obj'; rebuild all objects and libraries with the same compiler

and if this update is what it's expected to resolve it (I'd hope it brings fresh builds of these libraries), it needs to be merged or no PR against main can be green.

The PR at #9264 has a green coherency check (but has the build break), so that would support the theory that getting both in will fix everything.

@dipeshmsft dipeshmsft merged commit 77c6056 into main Jun 20, 2024
11 of 12 checks passed
@dipeshmsft dipeshmsft deleted the darc-main-847ec016-40a6-470e-9a8a-cfb01255fc23 branch June 20, 2024 08:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants