Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More canonical way of pulling in grpc headers. #80

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Mar 28, 2024

Old headers were still on 1.48.0; while grpc was 1.54.3. I bind these together now by calculating the source path in recipe and pulling directly into the build folder.

As we are not using (or building) this feature currently I have disabled it, but should be straight-forward to get working now with this change (just some -I needed).

Old headers were still on 1.48.0; while grpc was 1.54.3. I bind these together now by
calculating the source path in recipe and pulling directly into the build folder.

As we are not using (or building) this feature currently I have disabled it, but should
be straight-forward to get working now with this change (just some -I needed).
@szmyd szmyd requested a review from hkadayam March 28, 2024 17:25
@szmyd szmyd merged commit 7b704e0 into eBay:master Mar 28, 2024
12 checks passed
@szmyd szmyd deleted the remove_grpc_internal branch March 28, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant