-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade python version #284
base: main
Are you sure you want to change the base?
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
4ef89c3
to
6e9dd93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍 Please rebase your branch with the latest change.
# via | ||
# edx-django-utils | ||
# edx-opaque-keys | ||
stripe==10.0.0 | ||
stripe==11.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@attiyaIshaque there is major change in stripe version. Please consult the changelogs to see if there is any breaking change that needs to catered to in our code. Also please keep in mind to test all stripe related functionality on staging too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the Stripe change, @aht007 . So, I have it in mind that we need to test the Stripe functionality at this stage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to review the Changelogs. Can you consult stripe documentation. It is a major change.
Please resolve the conflicts. |
@attiyaIshaque |
Merge checklist:
Check off if complete or not applicable:
Post-merge: