Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade python version #284

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

huniafatima-arbi
Copy link
Member

@huniafatima-arbi huniafatima-arbi commented Oct 30, 2024

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

Copy link

github-actions bot commented Oct 30, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools/catalog_info
  constants.py
  commerce_coordinator/apps/commercetools/tests
  conftest.py
  commerce_coordinator/apps/core
  constants.py
  commerce_coordinator/apps/ecommerce
  data.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@iamsobanjaved iamsobanjaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@attiyaIshaque attiyaIshaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍 Please rebase your branch with the latest change.

# via
# edx-django-utils
# edx-opaque-keys
stripe==10.0.0
stripe==11.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attiyaIshaque there is major change in stripe version. Please consult the changelogs to see if there is any breaking change that needs to catered to in our code. Also please keep in mind to test all stripe related functionality on staging too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the Stripe change, @aht007 . So, I have it in mind that we need to test the Stripe functionality at this stage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to review the Changelogs. Can you consult stripe documentation. It is a major change.

@attiyaIshaque
Copy link
Member

Please resolve the conflicts.

@huniafatima-arbi
Copy link
Member Author

Please resolve the conflicts.

@attiyaIshaque
Rebased the PR and resolved conflicts. Please proceed with the merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants