Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Cases] Fix StatusFilter flaky test #189982

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Aug 6, 2024

fixes #177334

Summary

The failing test should render had waaay too many unnecessary tree traversals. I reduced the finds from 7 to 3 hopefully making the test significantly faster.

(I did the same on other tests but they weren't failing. Doesn't hurt though.)

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.16.0 labels Aug 6, 2024
@adcoelho adcoelho self-assigned this Aug 6, 2024
@adcoelho adcoelho requested a review from a team as a code owner August 6, 2024 15:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adcoelho adcoelho enabled auto-merge (squash) August 6, 2024 15:33
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit 1cb191f into elastic:main Aug 6, 2024
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/cases/public/components/all_cases - StatusFilter should render
5 participants