[APM] Show all alerts in service views & service inventory for consistency with entity inventory #202025
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, slo, and observability
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
|
/ci |
iblancof
commented
Nov 27, 2024
| @@ -65,9 +65,6 @@ export const useDetailViewRedirect = () => { | |||
| if (isBuiltinEntityOfType('service', entity)) { | |||
| return serviceOverviewLocator?.getRedirectUrl({ | |||
| serviceName: identityFieldsValue[identityFields[0]], | |||
| environment: entity.service?.environment | |||
| ? castArray(entity.service?.environment)[0] | |||
| : undefined, | |||
| }); | |||
There was a problem hiding this comment.
This change was agreed with product to avoid inconsistent data when accessing the service detail view with an environment other than "All" by default.
iblancof
added
release_note:skip
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
cc @iblancof |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #201565
This update ensures that the service inventory and service views display all alerts grouped by
service.name, regardless of index pattern. This provides consistent alert visibility across services.Note
The presence of two services with alerts in the "before" state, rather than one, is not due to any changes made in this PR, but rather because the alerts stopped being active while doing the screenshots.
Regarding the AC "Clicking through to the alerts app for the service should filter by just the entity ID," this was already working as expected.