[8.17] [Stack Monitoring] Do not add empty include array when retrieving logstash pipelines (#202039) #202100
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stash pipelines (elastic#202039) ## Summary This PR fixes the query that retrieves Logstash pipeline stats and metrics to be displayed in Stack Monitoring. The problem with the existing query is that a `terms` aggregation contains an empty `"include": []` filtering array, but that has the nasty effect of excluding everything and not returning anything, hence the screen is empty. The fix is to only add the `include` array if it's not empty. The PR also fixes a wrong field name used in a cardinality aggregation: `logstash.node.stats.logstash.uuid` instead of `logstash_stats.logstash.uuid` Closes elastic#202020 ### Checklist - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: Chris Earle <[email protected]> (cherry picked from commit b7e46bd)
kibanamachine
force-pushed
the
backport/8.17/pr-202039
branch
from
668fbc0
to
818dd36
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
💚 Build Succeeded
Metrics [docs]
cc @consulthys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.17:Questions ?
Please refer to the Backport tool documentation