Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granite version should be >=5.3.0 #367

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

shimataro
Copy link
Contributor

@shimataro shimataro commented Sep 20, 2021

Fixes #346
Granite v5.2 does not have AccelLabel, and v5.3 has it!

Copy link
Collaborator

@Alecaddd Alecaddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be done unless the base SDK is also updated in the build system.
You can do that if you want, but I'm waiting for elementary OS 7 to release with the new GTK4 SDK in order to update everything.

Copy link
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I personally feel we may want to merge this change for now, before we go ahead to port the app to GTK 4.

The Flatpak CI is failing due to another issue that the libaio package not found in the Debian server.

@danirabbit danirabbit merged commit b83f9c1 into ellie-commons:master Sep 24, 2024
2 of 3 checks passed
@ryonakano ryonakano removed the invalid label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error in HeaderBar.vala: The name AccelLabel' does not exist in the context of Granite'
4 participants