-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch cel-cpp to not break build #31894
Conversation
Signed-off-by: Raven Black <[email protected]>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor patch nits
@@ -0,0 +1,44 @@ | |||
From 09a072b4bb5a75e1df15beba29a9f13b1948ff8b Mon Sep 17 00:00:00 2001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we dont want the commit header - just the diff
patches = ["@envoy//bazel:cel-cpp.patch"], | ||
patches = [ | ||
"@envoy//bazel:cel-cpp.patch", | ||
"@envoy//bazel:cel-cpp-memory.patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets just use existing patch - no?
Not needed after #31872 |
- add patch from envoyproxy/envoy#31894 in lieu of disabling `-fno-sized-deallocation` - update to upstream release v1.29.1 - sync patches
Commit Message: Patch cel-cpp to not break build
Additional Description: This is google/cel-cpp#558
Fixes #31856
Risk Level: Low, does nothing except when build would be broken anyway.
Testing: Tried the broken build as
before and after this change. Before it fails as in #31856, after it builds.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a