Patch cel-cpp to not break build #31894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
phlax
reviewed
Jan 18, 2024
| @@ -0,0 +1,44 @@ | |||
| From 09a072b4bb5a75e1df15beba29a9f13b1948ff8b Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
i think we dont want the commit header - just the diff
| patches = ["@envoy//bazel:cel-cpp.patch"], | ||
| patches = [ | ||
| "@envoy//bazel:cel-cpp.patch", | ||
| "@envoy//bazel:cel-cpp-memory.patch", |
There was a problem hiding this comment.
lets just use existing patch - no?
|
Not needed after #31872 |
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Mar 6, 2024
- add patch from envoyproxy/envoy#31894 in lieu of disabling `-fno-sized-deallocation` - update to upstream release v1.29.1 - sync patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Patch cel-cpp to not break build
Additional Description: This is google/cel-cpp#558
Fixes #31856
Risk Level: Low, does nothing except when build would be broken anyway.
Testing: Tried the broken build as
before and after this change. Before it fails as in #31856, after it builds.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a