Feature/multi selection support + selection handler refacoring #50

sonique6784 · 2018-02-12T01:45:33Z

introduced a new ISelectableModel interface to store selection state, that need to be implemented by Cell, RH and CH in order to get a selection state
now selection state sit in each Cell, which prevent rendering issues.
introduced multiple selection
restored shadow selection display

Note: previous implementation was storing selection state into [Cell|RowHeader|ColumnHeader]ViewRecycler, which leaded to inconsistency in rendering (because RecyclerViews are re-used).

- now selection state sit in each Cell (instead of the CellRecyclerView, so the recycler doesn't get confuse) - introduced a new ISelectableModel interface, that need to be implemented by Cell, RH and CH in order to get a selection state - introduced multiple selection

fixed multi-selection clear when change between cell , row or column selection introduced multiselection in tableview sample

…nt UI issue with sorting

…plement in Cell, RowHeader or ColumnHeader

sonique6784

fixed conflict with README, ready to review

sonique6784 · 2018-02-12T05:32:03Z

...ava/com/evrencoskun/tableview/listener/itemclick/RowHeaderRecyclerViewItemClickListener.java

@@ -49,8 +49,8 @@ protected boolean clickAction(RecyclerView view, MotionEvent e) {
            int row = holder.getAdapterPosition();

            // Control to ignore selection color
-            if (!mTableView.isIgnoreSelectionColors()) {
-                mSelectionHandler.setSelectedRowPosition(holder, row);
+            if (!mTableView.isIgnoreSelectionColors() && mTableView.isSelectable()) {


Should we remove "isIgnoreSelectionColors()" and keep "isSelectable()", I've the feeling it's accomplishing the same purpose.

evrencoskun · 2018-02-14T05:03:27Z

Hi @sonique6784

These days, I am pretty busy. So, I haven't reviewed your codes. That's why I didn't approve it yet. I just want to evaluate your approach by a cup of coffee at a more relaxed time.

After the reviewing process, I'll give you feedback.

Thank you very much for your collaboration. 👍

sonique6784 · 2018-02-14T05:17:10Z

No worries, it's a big chunk of code, take your time. thanks

sonique6784 · 2018-03-06T04:42:57Z

fixed conflict, ready to merge

merge back

10erlosh · 2019-12-02T13:53:52Z

Hi @evrencoskun
any news on this?

MGaetan89

I've added some wording/code style comments. Feel free to take them into account if you wish.
I didn't really look at the logic itself.
You also have some conflicts to solve.

README.md

...c/main/java/com/evrencoskun/tableview/adapter/recyclerview/RowHeaderRecyclerViewAdapter.java

MGaetan89 · 2020-04-09T21:13:57Z

tableview/src/main/java/com/evrencoskun/tableview/handler/ISelectableModel.java

+/**
+ * Created by cedricferry on 8/2/18.
+ */
+


Remove empty line

MGaetan89 · 2020-04-09T21:14:07Z

tableview/src/main/java/com/evrencoskun/tableview/handler/ISelectableModel.java

+
+public interface ISelectableModel {
+    AbstractViewHolder.SelectionState getSelectionState();
+    void setSelectionState(AbstractViewHolder.SelectionState selectionState);


Add an empty line before the method

MGaetan89 · 2020-04-09T21:14:52Z

tableview/src/main/java/com/evrencoskun/tableview/handler/ISelectableModel.java

+ * Created by cedricferry on 8/2/18.
+ */
+
+public interface ISelectableModel {


If you can, it'd be nice to have the method of this interface annotated with @NonNull/@Nullable, based on your needs.

Co-Authored-By: Gaëtan Muller <[email protected]>

suggestion from MGaetan89 Co-Authored-By: Gaëtan Muller <[email protected]>

thanks to MGaetan89 Co-Authored-By: Gaëtan Muller <[email protected]>

moved the vertical detection AFTER checking if it the same RV. else it could set the mCurrentRVTouched to null and lead to unsync scrolling.

…n. This problem has been fixed.

… to pom xml file Also bumped version

# Conflicts: # README.md # app/src/main/java/com/evrencoskun/tableviewsample/MainFragment.java # app/src/main/java/com/evrencoskun/tableviewsample/tableview/model/Cell.java # tableview/src/main/java/com/evrencoskun/tableview/ITableView.java # tableview/src/main/java/com/evrencoskun/tableview/adapter/recyclerview/CellRecyclerViewAdapter.java # tableview/src/main/java/com/evrencoskun/tableview/adapter/recyclerview/CellRowRecyclerViewAdapter.java # tableview/src/main/java/com/evrencoskun/tableview/adapter/recyclerview/ColumnHeaderRecyclerViewAdapter.java # tableview/src/main/java/com/evrencoskun/tableview/adapter/recyclerview/RowHeaderRecyclerViewAdapter.java # tableview/src/main/java/com/evrencoskun/tableview/handler/SelectionHandler.java # tableview/src/main/java/com/evrencoskun/tableview/listener/itemclick/CellRecyclerViewItemClickListener.java

sonique6784 · 2020-04-20T12:18:46Z

@MGaetan89 @evrencoskun , I've fixed the conflicts and rested, it looks fine now.

sonique6784 · 2020-04-20T12:24:33Z

YoavSl · 2022-05-02T05:58:10Z

@sonique6784 @evrencoskun
Hey guys, any update on this? I really need the multiple row selection feature.
Thanks a lot

Cedric Ferry added 4 commits February 12, 2018 12:07

Merge branch 'master' into feature/multiSelectionSupport

3681353

re-enabled enableShadow with new SelectionHandler implementation

de59225

fixed multi-selection clear when change between cell , row or column selection introduced multiselection in tableview sample

Merge branch 'master' into feature/multiSelectionSupport

543ccea

sonique6784 force-pushed the feature/multiSelectionSupport branch 3 times, most recently from 6c8362a to 543ccea Compare February 12, 2018 22:30

Cedric Ferry and others added 5 commits February 13, 2018 09:32

check if table isSelectable before accessing SelectionState

4d1c793

added Selecting section

b881d10

used the RecyclerViewAdapters instead of the main dataset so it preve…

ae904be

…nt UI issue with sorting

added exception when TableView isSelectable and ISelectable is not im…

34146fe

…plement in Cell, RowHeader or ColumnHeader

Merge branch 'master' into feature/multiSelectionSupport

8e44ed5

sonique6784 commented Feb 13, 2018

View reviewed changes

Merge branch 'master' into feature/multiSelectionSupport

3086446

Merge pull request #10 from evrencoskun/master

2b422f9

merge back

MGaetan89 mentioned this pull request Apr 9, 2020

mutiple select row #305

Open

MGaetan89 reviewed Apr 9, 2020

View reviewed changes

sonique6784 and others added 9 commits April 19, 2020 17:41

Update README.md

3ac2e60

Co-Authored-By: Gaëtan Muller <[email protected]>

Update README.md

b8453f8

Co-Authored-By: Gaëtan Muller <[email protected]>

Update README.md

9819d32

Co-Authored-By: Gaëtan Muller <[email protected]>

Update README.md

0d3324d

Co-Authored-By: Gaëtan Muller <[email protected]>

Update Readme.md

fa50f50

suggestion from MGaetan89 Co-Authored-By: Gaëtan Muller <[email protected]>

Code formatting and minor copy updates

d158ae0

thanks to MGaetan89 Co-Authored-By: Gaëtan Muller <[email protected]>

moved the verticalScroll detection

6c62048

moved the vertical detection AFTER checking if it the same RV. else it could set the mCurrentRVTouched to null and lead to unsync scrolling.

Handle case where item is null

c51b947

Invalidate layout managers cache when changing the table dataset

0167dc6

evrencoskun and others added 26 commits April 19, 2020 18:45

Listener used to ignore click action and calling the long press actio…

e11508d

…n. This problem has been fixed.

Use generics types in ITableAdapter contract

004aab9

Updating Contributors

5c3b986

0.8.9 version has been released.

07d5a33

0.8.9 version has been released.

f17cfb0

Bug fix of evrencoskun#276

fc4b497

A sponsorship URL has been inserted.

55c41d1

A sponsorship URL has been inserted.

03c0864

Documentation has been moved to the wiki page.

52f89ae

Documentation has been moved to the wiki page

21aa792

Patreon user name has been changed.

19c494a

The DoubleClick events have been added.

166f548

The DoubleClick events have been added.

c45f165

getVisibilityHandler function has been added.

6f4b3e8

Xently-UI app has been added in the sample apps list.

a68a02f

Fix click listener setup in TableView

6d0fd2a

Enable click events in sample app

b4f7bb0

Fix crash on double click on a cell

a5e94d4

Fix crash when calling hideColumn

52b02ee

evrencoskun#303 issue has been fixed.

7b05330

0.8.9.2 version has been released.

35ef9dd

0.8.9.2 version has been released.

a76c444

License inconsistency, Update bintray-release info and Append license…

1be6e29

… to pom xml file Also bumped version

Merge branch 'master' into feature/multiSelectionSupport

b62bf0a

marcosmichel89 mentioned this pull request Feb 28, 2021

Support MultiSelect #366

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/multi selection support + selection handler refacoring #50

Feature/multi selection support + selection handler refacoring #50

sonique6784 commented Feb 12, 2018

sonique6784 left a comment

sonique6784 Feb 12, 2018

evrencoskun commented Feb 14, 2018

sonique6784 commented Feb 14, 2018

sonique6784 commented Mar 6, 2018

10erlosh commented Dec 2, 2019

MGaetan89 left a comment

MGaetan89 Apr 9, 2020

MGaetan89 Apr 9, 2020

MGaetan89 Apr 9, 2020

sonique6784 commented Apr 20, 2020

sonique6784 commented Apr 20, 2020

YoavSl commented May 2, 2022

Feature/multi selection support + selection handler refacoring #50

Are you sure you want to change the base?

Feature/multi selection support + selection handler refacoring #50

Conversation

sonique6784 commented Feb 12, 2018

sonique6784 left a comment

Choose a reason for hiding this comment

sonique6784 Feb 12, 2018

Choose a reason for hiding this comment

evrencoskun commented Feb 14, 2018

sonique6784 commented Feb 14, 2018

sonique6784 commented Mar 6, 2018

10erlosh commented Dec 2, 2019

MGaetan89 left a comment

Choose a reason for hiding this comment

MGaetan89 Apr 9, 2020

Choose a reason for hiding this comment

MGaetan89 Apr 9, 2020

Choose a reason for hiding this comment

MGaetan89 Apr 9, 2020

Choose a reason for hiding this comment

sonique6784 commented Apr 20, 2020

sonique6784 commented Apr 20, 2020

YoavSl commented May 2, 2022