feat: implement F3 CLI to list power table and proportional power at instance #12698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement utility CLIs to: * get the power table used by F3 at a given instance ID. * get total proportional power of a list of actors at a given instance ID. These utilities allow us to debug the exact participation power for an instance without having to manually calculate it or estimate it from the latest power.
masih
commented
Nov 14, 2024
rvagg
reviewed
Nov 18, 2024
|
It will be slightly annoying, but can you separate the commands into separate vars? The diff is hard to read because it got too wide. |
Sure; done. |
|
The diff looks more verbose now unfortunately. If this is hard to review, can break up the vars in a separate PR then rebase this one. Please let me know if you'd prefer it that way @Kubuxu |
Kubuxu
approved these changes
Nov 18, 2024
rvagg
reviewed
Nov 19, 2024
8 tasks
59 tasks
rjan90
pushed a commit
that referenced
this pull request
Nov 26, 2024
…instance (#12698) * Implement F3 CLI to list power table and proportional power at instance Implement utility CLIs to: * get the power table used by F3 at a given instance ID. * get total proportional power of a list of actors at a given instance ID. These utilities allow us to debug the exact participation power for an instance without having to manually calculate it or estimate it from the latest power. * Update changelog * Address lint issue * Regenerate CLI docs * Take instance ID via flag and actor IDs as args * Reduce indentation by defiling top level vars * Work around bug in docsgencli by using one-liner usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Implement utility CLIs to:
These utilities allow us to debug the exact participation power for an instance without having to manually calculate it or estimate it from the latest power.
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: