chore(gateway): add new methods #12727
Open
+1,265
−464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Nov 27, 2024
| @@ -34,6 +35,12 @@ import ( | |||
| // * Generate openrpc blobs | |||
|
|
|||
| type Gateway interface { | |||
| ChainGetNode(ctx context.Context, p string) (*IpldObject, error) | |||
There was a problem hiding this comment.
tbh I can't see this one making it to the v2 API that's under development now without a really good use-case, are people asking for it?
There was a problem hiding this comment.
Yes, this method was added by request of a user from Neti-Soft
rvagg
reviewed
Nov 27, 2024
| StateMinerSectors(context.Context, address.Address, *bitfield.BitField, types.TipSetKey) ([]*miner.SectorOnChainInfo, error) | ||
| StateMinerFaults(context.Context, address.Address, types.TipSetKey) (bitfield.BitField, error) | ||
| StateMinerAvailableBalance(context.Context, address.Address, types.TipSetKey) (types.BigInt, error) | ||
| StateMarketParticipants(context.Context, types.TipSetKey) (map[string]MarketBalance, error) |
There was a problem hiding this comment.
This one isn't small - mainnet currently gives a map with 6175 entries, 361Kb of JSON. It's not inefficient, so probably not too big a problem to expose, except for the fact that it's a big chunk of data for a simple call. Are people asking for this?
There was a problem hiding this comment.
Yes, all these methods were added by requests of different users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.