Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Improved SetAs actions #16480

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Code Quality: Improved SetAs actions #16480

wants to merge 12 commits into from
+75 −72

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Nov 18, 2024 •
edited
Loading

Resolved / Related Issues

  • Annotated that the service methods may throw COMException
  • Throw COMException when failed in all the com methods
  • Release the PIDLs properly
  • Use stackalloc

Steps used to test these changes

  1. Set as wallpaper
  2. Set as slideshow
  3. Set as app background

@0x5bfa 0x5bfa changed the title Init Code Quality: Improved SetAs actions Nov 18, 2024
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Nov 18, 2024
yaira2
yaira2 reviewed Nov 26, 2024
View reviewed changes
src/Files.App/Actions/Content/Background/SetAsSlideshowBackgroundAction.cs

public override Task ExecuteAsync(object? parameter = null)
{
var paths = context.SelectedItems.Select(item => item.ItemPath).ToArray();
if (!IsExecutable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix this as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this per #16480 (comment)
Sounds not good to you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hishitetsu is this what you intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishitetsu hishitetsu hishitetsu left review comments

@yaira2 yaira2 yaira2 left review comments

Assignees
No one assigned
Labels
changes requested Changes are needed for this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @yaira2 @hishitetsu