Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-pgquery to avoid CGO, so that plugins can compile on multiple platforms #17

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Dec 3, 2023

This is a workaround using WebAssembly introduced in pganalyze/pg_query_go#103

Ticket(s)

N/A

Description

This PR introduces the go-pgquery library that uses WebAssembly and wazero to compile the query parser (pganalyze/pg_query_go#103), so that we don't need to use CGO anymore, which subsequently causes build issues due to the lack of support for Windows (and other platforms) in pg_query_go (for now).

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

…platforms

This is a workaround using WebAssembly introduced in pganalyze/pg_query_go#103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant