Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #32 #35

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Fix #32 #35

merged 4 commits into from
Jun 11, 2024

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Jun 11, 2024 •
edited
Loading

QiParsers will trim leading spaces even when trim_ws is FALSE.

minty/src/QiParsers.h

Lines 89 to 90 in 7d08b05

while (p != *endptr && (*p == ' ' || *p == '\t'))
++p;

And therefore, class(parse_guess(" 1", trim_ws = FALSE)) is still numeric.

@chainsawriot chainsawriot marked this pull request as ready for review June 11, 2024 10:36
@chainsawriot chainsawriot merged commit 9973c33 into v0.0 Jun 11, 2024
7 checks passed
@chainsawriot chainsawriot deleted the trim branch June 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chainsawriot