Rust: add some performance diagnostics #18116
Open
+634
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This outputs some duration counts for various parts of the extraction process in the database in the form of telemetry diagnostics. The diagnostics format was preferred to putting things in the relational database as that will scale better to code scanning and is more flexible as for the data we can put into it without passing through the dbscheme. Also, although it's not the case yet, it will be possible to output diagnostics even if creation of the database fails.
added 5 commits
November 26, 2024 16:48
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+9
to
+11
| /** | ||
| * The string representation of this extractor step. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
Comment on lines
+19
to
+21
| /** | ||
| * The action this extractor step carried out. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
Comment on lines
+24
to
+26
| /** | ||
| * The file the extractor step was carried out on. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
Comment on lines
+29
to
+31
| /** | ||
| * The duration of the extractor step in milliseconds. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This outputs some duration counts for various parts of the extraction process in the database in the form of a per-file breakdown in the QL DB and a summary as telemetry diagnostics.
The QL DB entities do not use
codegenbecause we currently can't include "extern" stuff (likeFilein this case) into the generation machinery. This might be improved in the future.