-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling two-factor authentication documentation update #34830
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@georgethemarmot Thank you for opening a PR! ✨ While your changes appear to be correct, I'll get this triaged for review by our technical writing team to validate content / style changes 💛 |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
how can i contribute ? |
@kashyapanjali Hello! 👋 While there aren't any opportunities to contribute regarding this PR, take a look at our help wanted section to find open issues you can work on ✨ |
...o-factor-authentication-2fa/disabling-two-factor-authentication-for-your-personal-account.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @georgethemarmot—
Thanks for raising this PR and identifying the discrepancy. You're absolutely right that we need to change this, but I've amended your proposals to fit with our style guide.
One more thing is that the image you've proposed doesn't conform to the guidelines in https://docs.github.com/en/contributing/writing-for-github-docs/creating-screenshots so I created a new one that I'll add in a comment below, that you can add to your branch.
Once you've accepted all the changes we can get this merged. Many thanks!
|
||
![Screenshot of an account's 2FA settings. A green button labeled "Enabled" is outlined in orange.](/assets/images/help/2fa/disable-two-factor-authentication.png) | ||
![Screenshot of an account's 2FA settings. The option menu is outlined in red.](/assets/images/help/2fa/disable-two-factor-authentication.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![Screenshot of an account's 2FA settings. The option menu is outlined in red.](/assets/images/help/2fa/disable-two-factor-authentication.png) | |
![Screenshot of an account's 2FA settings. The ellipsis button (three dots) is highlighted with a dark orange outline.](/assets/images/help/2fa/disable-two-factor-authentication.png) |
Context in https://docs.github.com/en/contributing/writing-for-github-docs/creating-screenshots
@@ -38,9 +38,9 @@ To remove yourself from your organization: | |||
{% data reusables.user-settings.access_settings %} | |||
{% data reusables.user-settings.security %} | |||
{% ifversion 2fa-reconfiguration-inline-update %} | |||
1. Hover over **Enabled**, then click **Disable**. | |||
1. Click on the three dots option menu, then click **Disable two-factor authentication**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Click on the three dots option menu, then click **Disable two-factor authentication**. | |
1. Click {% octicon "kebab-horizontal" aria-label="The horizontal kebab icon" %}, then select **Disable two-factor authentication**. |
Context in https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide#lists-and-list-items and https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide#use-clear-consistent-symbols-and-labels
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process. |
@georgethemarmot Howdy! 👋 We wanted to check in and see if you've had a chance to review @subatoi's suggestions, including the new image he provided! The branch conflicts will also need to be resolved as well 💛 If you'd rather us fix this internally, we're more than happy to do so! |
Why:
Documentation was not up to date with website changes
What's being changed (if available, include any code snippets, screenshots, or gifs):
Image and description of where to disable 2fa
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.