Merge pull request #85 from github/ref-bug

fix: move action reference outside table
github · Aug 1, 2023 · 7296d9d · 7296d9d
2 parents 8dd9b24 + 9c97193
commit 7296d9d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/markdown_writer.py b/markdown_writer.py
@@ -150,7 +150,7 @@ def write_to_markdown(
                         file.write(f" {issue.label_metrics[label]} |")
             file.write("\n")
         file.write(
-            "_This report was generated with the [Issue Metrics Action](https://github.com/github/issue-metrics)_\n"
+            "\n_This report was generated with the [Issue Metrics Action](https://github.com/github/issue-metrics)_\n"
         )
 
     print("Wrote issue metrics to issue_metrics.md")

diff --git a/test_markdown_writer.py b/test_markdown_writer.py
@@ -85,7 +85,7 @@ def test_write_to_markdown(self):
             "| Issue 1 | https://github.com/user/repo/issues/1 | 1 day, 0:00:00 | "
             "2 days, 0:00:00 | 3 days, 0:00:00 | 1 day, 0:00:00 |\n"
             "| Issue 2 | https://github.com/user/repo/issues/2 | 3 days, 0:00:00 | "
-            "4 days, 0:00:00 | 5 days, 0:00:00 | 2 days, 0:00:00 |\n"
+            "4 days, 0:00:00 | 5 days, 0:00:00 | 2 days, 0:00:00 |\n\n"
             "_This report was generated with the [Issue Metrics Action](https://github.com/github/issue-metrics)_\n"
         )
         self.assertEqual(content, expected_content)
@@ -158,7 +158,7 @@ def test_write_to_markdown_with_vertical_bar_in_title(self):
             "| Issue 1 | https://github.com/user/repo/issues/1 | 1 day, 0:00:00 | "
             "2 days, 0:00:00 | 3 days, 0:00:00 | 1 day, 0:00:00 |\n"
             "| feat&#124; Issue 2 | https://github.com/user/repo/issues/2 | 3 days, 0:00:00 | "
-            "4 days, 0:00:00 | 5 days, 0:00:00 | 2 days, 0:00:00 |\n"
+            "4 days, 0:00:00 | 5 days, 0:00:00 | 2 days, 0:00:00 |\n\n"
             "_This report was generated with the [Issue Metrics Action](https://github.com/github/issue-metrics)_\n"
         )
         self.assertEqual(content, expected_content)
@@ -258,7 +258,7 @@ def test_writes_markdown_file_with_non_hidden_columns_only(self):
             "| Title | URL |\n"
             "| --- | --- |\n"
             "| Issue 1 | https://github.com/user/repo/issues/1 |\n"
-            "| Issue 2 | https://github.com/user/repo/issues/2 |\n"
+            "| Issue 2 | https://github.com/user/repo/issues/2 |\n\n"
             "_This report was generated with the [Issue Metrics Action](https://github.com/github/issue-metrics)_\n"
         )
         self.assertEqual(content, expected_content)