Remove unmaintained child-process-promise #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koesie10
force-pushed
the
koesie10/switch-to-execa
branch
3 times, most recently
from
6e3497b
to
f625fec
Compare
koesie10
changed the title
koesie10
force-pushed
the
koesie10/switch-to-execa
branch
from
f625fec
to
f3e9103
Compare
koesie10
force-pushed
the
koesie10/switch-to-execa
branch
from
f3e9103
to
87a470d
Compare
norascheuch
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
child-process-promiseseems to be unmaintained, so this removes it and replaces it by creating the promise manually and usingcross-spawnfor spawning (likechild-process-promisedid).The only time this code is actually used is when running tests. Running CodeQL tests in
github/codeqlstill works, so there should be no changes in behavior.