Add 'compare performance' view #3843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a dropdown with (at present) two options: sorting by delta and sorting by absolute delta.
This ensures we can use hooks after the check in the main component
A very hacky implementation that simply instantiates an empty `PerformanceOverviewScanner` as the "from" column (i.e. with all values empty). To see it in action, select a single query run in the query history and pick "Compare Performance" from the context menu. Then select the "Single run" option when prompted.
Only contains formatting changes
Predicate names can't be empty, but it can happen with the renaming feature added in the next commit.
asgerf
force-pushed
the
asgerf/compare-perf-view
branch
2 times, most recently
from
13e78a6
to
ec223fa
Compare
asgerf
force-pushed
the
asgerf/compare-perf-view
branch
from
ec223fa
to
aa528c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the 'Compare Performance' UI from the hackathon.
Activate via right-clicking on a query history item
Shows overview of predicate evaluation costs
Click a predicate to show its pipeline(s) and tuple counts per step
Changes since the hackathon:
useMemoand moved some state into subcomponents where a state change cause as much re-rendering.Despite my attempts at cleaning the commit history, it might actually be easiest to review as one giant diff.