Fix Spurious Compilation Errors #3845
Open
+67
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeluka
commented
Nov 27, 2024
| @@ -792,12 +792,16 @@ async function activateWithInstalledDistribution( | |||
| const languageSelectionPanel = new LanguageSelectionPanel(languageContext); | |||
| ctx.subscriptions.push(languageSelectionPanel); | |||
|
|
|||
| void extLogger.log("Initializing CodeQL language server."); | |||
| const languageClient = createLanguageClient(qlConfigurationListener); | |||
There was a problem hiding this comment.
this changes the initialization order of things because we now inject the language client into sub-components. It seems to work fine for me locally.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ions/ql-vscode/test/vscode-tests/cli-integration/local-queries/skeleton-query-wizard.test.ts
Fixed
Show fixed
Hide fixed
...ions/ql-vscode/test/vscode-tests/cli-integration/local-queries/skeleton-query-wizard.test.ts
Fixed
Show fixed
Hide fixed
kaeluka
force-pushed
the
kaeluka/4654-fix-spurious-errors
branch
2 times, most recently
from
656363b
to
a97fbd6
Compare
extensions/ql-vscode/test/vscode-tests/minimal-workspace/qlpack-generator.test.ts
Fixed
Show fixed
Hide fixed
kaeluka
force-pushed
the
kaeluka/4654-fix-spurious-errors
branch
from
a97fbd6
to
9c87113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://github.com/github/codeql-core/issues/4654
Dear Reviewer
~/.codeql/packagessubdirectories, ...). Chances are, there's room for improvement.