Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: use of sized deallocation in base/memory.h wo check #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: use of sized deallocation in base/memory.h wo check #558

wants to merge 1 commit into from

Commits on Jan 18, 2024

  1. Fix: use of sized deallocation in base/memory.h wo check 

    Dependant projects that do not use `-fsized-deallocation`
would not compile with the call to delete(void*, size_t, align).

There are other places that already check for
`defined(__cpp_sized_deallocation)` and this patch just shares
this practice.

Testing:

    // fix .bazelrc to have:
    build --cxxopt=-fno-sized-deallocation

    $ bazel build --verbose_failures //base:\*

Signed-off-by: Ivan Prisyazhnyy <[email protected]>
    @sitano
    sitano committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    09a072b View commit details
    Browse the repository at this point in the history