Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the designated payer when building an EVM transactions from … #16828

Open
wants to merge 1 commit into
base: release/0.57
Choose a base branch
from

Conversation

JivkoKelchev
Copy link
Contributor

@JivkoKelchev JivkoKelchev commented Nov 28, 2024

Description:
Cherry-pick #16708

…scheduled transactions (#16708)

Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Valentin Tronkov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Co-authored-by: Valentin Tronkov <[email protected]>
Co-authored-by: ibankov <[email protected]>
Co-authored-by: Michael Tinker <[email protected]>
Co-authored-by: Joseph S. <[email protected]>
@JivkoKelchev JivkoKelchev self-assigned this Nov 28, 2024
@JivkoKelchev JivkoKelchev added this to the v0.57 milestone Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.59%. Comparing base (1b4339d) to head (b85211e).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.57   #16828      +/-   ##
==================================================
- Coverage           63.59%   63.59%   -0.01%     
+ Complexity          20399    20398       -1     
==================================================
  Files                2547     2547              
  Lines               94875    94872       -3     
  Branches             9913     9913              
==================================================
- Hits                60335    60332       -3     
  Misses              30922    30922              
  Partials             3618     3618              
Files with missing lines Coverage Δ
...ontract/impl/exec/ContextTransactionProcessor.java 80.55% <100.00%> (ø)
...ce/contract/impl/infra/HevmTransactionFactory.java 92.30% <100.00%> (-0.18%) ⬇️

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1b4339d) 97640 63764 65.31%
Head commit (b85211e) 97637 (-3) 63761 (-3) 65.30% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16828) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@JivkoKelchev JivkoKelchev marked this pull request as ready for review November 28, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant