-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node id should start from 1
#884
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
This reverts commit ad20df0. Signed-off-by: Jeromy Cannon <[email protected]>
0479213
to
f515496
Compare
Signed-off-by: Jeffrey Tang <[email protected]>
…into 00878-D-node-alias
Signed-off-by: Jeffrey Tang <[email protected]>
1 similar comment
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 83.80% 83.81%
=======================================
Files 49 49
Lines 14934 14934
Branches 1469 1438 -31
=======================================
+ Hits 12516 12517 +1
- Misses 2269 2294 +25
+ Partials 149 123 -26 |
Description
This pull request changes the following:
Related Issues
To test the custom Taskfile, run the following command
task helper:cluster:create task helper:cluster:setup cd examples/custom-network-config task default task show:ips task clean