Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node id should start from 1 #884

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Nov 26, 2024

Description

This pull request changes the following:

  • Fixed the example task file incorrect path to helper file and node id still starts from 0

Related Issues

To test the custom Taskfile, run the following command

task helper:cluster:create
task helper:cluster:setup
cd examples/custom-network-config
task default 
task show:ips
task clean

@JeffreyDallas JeffreyDallas requested review from a team as code owners November 26, 2024 19:39
@JeffreyDallas JeffreyDallas requested review from matteriben and jeromy-cannon and removed request for jeromy-cannon November 26, 2024 19:39
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Test Results - Linux

  1 files  ±0   36 suites  ±0   2s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3bc826. ± Comparison against base commit 1f6f057.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Test Results - Windows

  1 files  ±0   36 suites  ±0   16s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3bc826. ± Comparison against base commit 1f6f057.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>
JeffreyDallas and others added 4 commits November 26, 2024 20:13
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Copy link
Contributor

E2E Test Report

 13 files  ±0   94 suites  ±0   54m 43s ⏱️ +13s
199 tests ±0  199 ✅ ±0  0 💤 ±0  0 ❌ ±0 
202 runs  ±0  202 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3bc826. ± Comparison against base commit 1f6f057.

1 similar comment
Copy link
Contributor

E2E Test Report

 13 files  ±0   94 suites  ±0   54m 43s ⏱️ +13s
199 tests ±0  199 ✅ ±0  0 💤 ±0  0 ❌ ±0 
202 runs  ±0  202 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3bc826. ± Comparison against base commit 1f6f057.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1f6f057) 14906 12666 84.97%
Head commit (d3bc826) 14934 (+28) 12694 (+28) 85.00% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#884) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (1f6f057) to head (d3bc826).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   83.80%   83.81%           
=======================================
  Files          49       49           
  Lines       14934    14934           
  Branches     1469     1438   -31     
=======================================
+ Hits        12516    12517    +1     
- Misses       2269     2294   +25     
+ Partials      149      123   -26     

see 11 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network node alias -1 bug
2 participants