-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(asciidoctor): handle metadata #191
base: master
Are you sure you want to change the base?
Conversation
Adds metadata handling to the asciidoctor task. The asciidoctor task will now: 1. read asciidoctor attributes and add them as metadata 2. expose metadata to the asciidoctor process as attributes Both processes are executed independently from each other.
As promised (#100), a new Asciidoctor pull request, for handling metadata. Some notes for review:
|
As mentioned I'm also working on getting asciidoctor-diagram to function. I'm aiming for the inline svg solution (asciidoctor/asciidoctor#1301) as a start, not having to deal with the Boot file handing. Somehow the JRuby container cannot access the binaries on my system for the actual image generation, so that'll take some more time. Similarly perhaps syntax highlighting will become a feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @nicorikken
Thanks for your hard work! Maybe this PR has never been merged because it lacks tests?
You may find useful links in #228.
Adds metadata handling to the asciidoctor task. The asciidoctor task will now:
Both processes are executed independently from each other.