Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer dependencies, test newer GHC #52

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Allow newer dependencies, test newer GHC #52

merged 1 commit into from
Nov 27, 2023

Conversation

ysangkok
Copy link
Contributor

No description provided.

@ysangkok
Copy link
Contributor Author

We should rerun this when

has been released

@ysangkok
Copy link
Contributor Author

@maksbotan Would it be possible for you to do the revisions for servant-js contained in this PR?

@maksbotan
Copy link
Contributor

@ysangkok 9.8 CI still fails:

Error: cabal-3.10.2.0: Could not resolve dependencies:
[__0] trying: servant-js-0.9.4.2 (user goal)
[__1] trying: text-2.1/installed-1f8a (dependency of servant-js)
[__2] next goal: servant (dependency of servant-js)
[__2] rejecting: servant-0.20.1 (conflict: text => bytestring==0.12.0.2/installed-4571, servant => bytestring>=0.10.8.1 && <0.12)

Perhaps you need to bump bytestring on servant as well? Can you try it in this PR with allow-newer?

@ysangkok ysangkok closed this Nov 27, 2023
@ysangkok ysangkok reopened this Nov 27, 2023
@ysangkok
Copy link
Contributor Author

@maksbotan The issue is that bytestring was bumped in a separate PR. It would be preferable if we also had revisions for all of these bumps. If we use allow-newer, it will only solve the issue in this package's CI suite.

@maksbotan
Copy link
Contributor

Ah, I see. There were no Hackage revisions for that PR, let me fix that.

@maksbotan maksbotan merged commit bf57ad6 into haskell-servant:master Nov 27, 2023
15 of 16 checks passed
@maksbotan
Copy link
Contributor

Revised on Hackage.

@ysangkok ysangkok deleted the janus/allow-new-deps branch November 27, 2023 22:19
@ysangkok
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants