USE URL from API when private #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattclegg
force-pushed
the
USE-URL-from-API-when-private
branch
from
54005f7
to
afc8918
Compare
Signed-off-by: Matt Clegg <[email protected]>
mattclegg
force-pushed
the
USE-URL-from-API-when-private
branch
from
afc8918
to
b0489e2
Compare
|
What is the motivation for that? Sorry, I did not quite understand that. Also what is the relation with the link you added with this PR? |
|
I'm trying to use a chart that has been published to a private GitHub repository. The BrowserDownloadURL from GitHub API doesn't work with "personal access tokens" (which I need to access to the private repository). The reference to the link is because I've also had to update the helm binary to send the correct headers when downloading the chart from a private GitHub repository. So now I just need to update index.yaml to use; https://api.github.com/repos/$OWNER/$REPO/releases/assets/$ASSET_ID |
Signed-off-by: Matt Clegg <[email protected]>
|
+1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cpanato I'd like to support using the URL from the API instead of the BrowserDownloadURL as that appears to be the only one that supports personal access tokens on private repos.
ref