Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require coverage>=7.4.2 #129

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

radarhere
Copy link

python-pillow#8514 (comment)

coverage vs coverage>=7.4.2: before, theoretically we could have installed coverage older than 7.4.2 here. I think that was unlikely and it's safer to require the newer version.

I'm a little confused, because the current state of the PR relaxes the coverage requirement, but

But if we want to run it, trove-classifiers>=2024.10.12 is a required dependency. We shouldn't really just hope we end up with a newer one installed into the system.

is an argument that we shouldn't relax requirements?

This PR requires coverage>=7.4.2 in pyproject.toml, to be consistent.

@hugovk
Copy link
Owner

hugovk commented Nov 6, 2024

Thanks, I got the coverage one the wrong way round.

@hugovk hugovk merged commit e5f2874 into hugovk:tests-trove-extra Nov 6, 2024
45 of 46 checks passed
@radarhere radarhere deleted the tests-trove-extra branch November 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants