-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video recorder functionality #67
base: main
Are you sure you want to change the base?
Conversation
I like this, I did something similar (but simpler) in my local fork : https://github.com/ssssam/hydra/tree/sam/record |
Interesting! Curiuos: Why did you go for RecordRTC as a dependency over WebMediaRecorder? Do you have more control over the quality of the video? I don't seem to be able to get this right :( |
I actually didn't test WebMediaRecorder, I used RecordRTC as the first thing I found. I didn't notice any quality issues with it. |
Hi, I really like the UI idea. A video recorder already exists in hydra-synth as something you can call directly from the code (https://github.com/ojack/hydra-synth/blob/master/src/video-recorder.js). In general I have not been happy with the quality using the native MediaRecorder, and that is why it isn't documented :)
I like the UI in this pull request, but I want to get a better understanding of the quality issues before adding this to the website. It would be great if someone wanted to investigate and do a side-by-side comparison of quality settings. Also, updates to this should go into hydra-synth rather than hydra, except for the ui-button as a way to interface with the recorder. I would also like to add a non-realtime renderer of lossless quality (similar in concept to https://github.com/spite/ccapture.js/) ... it is something I have done locally but not in the browser. |
Side note: at one point you could also do |
the vidRecorder function is cool! it would be nice, if there was a high quality recording/exporting method. to show non-nerdy friends beautiful fluently animations without the code overlay and even being able to make a video montage. @ojack did you make ccapture.js work with hydra? how? maybe Or am I missing something, another way to capture? |
I wanted to export some videos from Hydra, but my screen recording tool kept crashing. I figured I could capture the canvas directly and add some convenient UI. I'm not sure if there's any interest in this, but figured I'd open this PR to make it visible. Feel free to close if not relevant :)
Todo