refactor(schema_derive): use error emitter instead of bailing out early #5131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
dima74
as code owners
DCNick3
force-pushed
the
use-emitter-in-iroha-schema-derive
branch
2 times, most recently
from
d01c492
to
9969f06
Compare
4 tasks
mversic
approved these changes
Oct 8, 2024
0x009922
approved these changes
Oct 8, 2024
Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
… clause Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
mversic
force-pushed
the
use-emitter-in-iroha-schema-derive
branch
from
9969f06
to
60d1cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does applies a refactor to use an error emitter instead of bailing early in the iroha_schema derive macros, like was done in #3897.
The second commit is just a drive-by refactor removing some code duplication in where clause generation.
This is in preparation for a PR adding smart trait bound derivation (#5130).