Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macros): Implement a derive-where-like macro for serde #5220

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Nov 5, 2024

Context

Needed for me to finish integrating query projections (#5063) into the iroha codebase.

Completes the second part of and closes #5130.

Solution

A macro with a syntax similar to derive-where that emits the #[serde(bounds(...))] attributes


Review notes

  • The first commit is just a refactor splitting iroha_derive crate into files; the second commit is the interesting part

Checklist

  • I've read CONTRIBUTING.md.
  • I've written tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@s8sato s8sato self-assigned this Nov 12, 2024
@mversic mversic enabled auto-merge (squash) November 12, 2024 09:21
@mversic mversic merged commit e266b64 into hyperledger-iroha:main Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associated types and derive trait bounds
3 participants