skip impala and trino in another test

ibis-project · Sep 20, 2024 · 006cfa7 · 006cfa7
1 parent 4692e6c
commit 006cfa7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ibis/backends/__init__.py b/ibis/backends/__init__.py
@@ -10,7 +10,6 @@
 import re
 import sys
 import urllib.parse
-import urllib.request
 import weakref
 from io import BytesIO
 from pathlib import Path

diff --git a/ibis/backends/tests/test_register.py b/ibis/backends/tests/test_register.py
@@ -472,6 +472,12 @@ def test_read_parquet_url_request(con, url, data_dir, in_table_name, monkeypatch
     pytest.importorskip("pyarrow.parquet")
     fsspec = pytest.importorskip("fsspec")
 
+    if con.name in ("trino", "impala"):
+        # TODO: remove after trino and impala have efficient insertion
+        pytest.skip(
+            "Both Impala and Trino lack efficient data insertion methods from Python."
+        )
+
     fname = Path("functional_alltypes.parquet")
     fname = Path(data_dir) / "parquet" / fname.name
     mock_calls = []