Andreas dickow patch 1 #1121
Closed
Andreas dickow patch 1 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In master-master database setups, a race condition on auto_now and auto_add_now fields leads to database crashes. Therefore the attempt_time should be determined already in django to avoid different time stamp issues on create or update statements
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
- Coverage 94.63% 94.51% -0.13%
==========================================
Files 34 35 +1
Lines 1137 1148 +11
Branches 209 211 +2
==========================================
+ Hits 1076 1085 +9
- Misses 47 48 +1
- Partials 14 15 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Missing blank line
reformat models for prospector
|
I'm closing this as there has been no discussion on the implementation alternatives. I'm not opposed to adding this feature but it would be nice to discuss implementing this functionality without overwriting model methods and adding data layer logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the pull request fixes a problem with master-master replication database setups, as often found in large scale and fail safe systems.
A race condition by database function induced timestamp generation is circumvented by avoiding django auto_add and auto_add_now options
Fixes # (issue)
Before submitting