Added user reference to AccessLog #1122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps identify the logs and trace them to a given user.
Note that the existing
username
field is modifiable, meaning if changed, theAccessLog
can't be traced back to any user.The
username
is inAccessBase
anyway and not inAccessLog
which must be tied to auser
.If there is any chance of this being merged, I'll work further on it, since this will most likely break all previous versions.
AccessLog
having a reference toUser
simply makes sense.I don't think it's even possible to have a useful
AccessLog
without an existingUser
model.