Fix hardcoded color range in tonemapx LUTs #470
Conversation
Signed-off-by: nyanmisaka <[email protected]>
|
I have a local version to make more changes to keep GPU/CPU implementations consistent to replace this because our GPU implementation side also has some inconsistencies abut range and peak handling that is different from the software one. But I noticed some design differences in yours so maybe we need to discuss further. |
| + | ||
| + for (i = 0; i < 32768; i++) { | ||
| + double v1 = (i - 2048.0f) / 28672.0f; | ||
| + double v1 = (i - s->lut_off) / 32767.0f; |
There was a problem hiding this comment.
Why it is not divided by limited range 28672.0f when the input is in limited range now? In my implementation this is changed with the lut_off.
There was a problem hiding this comment.
Because doing so gives incorrect colors based on testing, too bright and loses too much detail.
There was a problem hiding this comment.
This is due to still incorrect range handling though, as the output rgb color after yuv2rgb is always in full range this limited range lut should not be used on those colors. I'm going to push my version soon.
Changes
Issues