Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it work for react 18 #1392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make it work for react 18 #1392

wants to merge 2 commits into from

Conversation

collinschaafsma
Copy link

@collinschaafsma collinschaafsma commented Aug 3, 2023 •
edited
Loading

makes it work for react 18, tested in next 13 using app dir, probably a cleaner way, but this will work

@collinschaafsma collinschaafsma mentioned this pull request Aug 4, 2023
Open
@suhmantha1
Copy link

Are there plans to merge this ? I'm also having issues getting modals to work with react 18

@NikitaLukashuk1
Copy link

@collinschaafsma how did you build the app?
I can't resolve dependencies with react 18, because some of libs requires lower version

@fhernandez-lq
Copy link

@jpuri @nairvishal are there plans to merge this one? also facing this problem with modals and react 18

@AngelicaGar
Copy link

I have the same problem. Is there any way to merge this? @collinschaafsma @nairvishal @jpuri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nairvishal nairvishal nairvishal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@collinschaafsma @suhmantha1 @NikitaLukashuk1 @fhernandez-lq @AngelicaGar @nairvishal