[jsk_perception] Add Visual Grounding with GroundingDINO #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll review it on Saturday |
mqcmd196
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Do you think creating this new msg (ClassificationResult + RectArray) is necessary? There were so many cases of returning detected objects' rect array.
To see jsk-ros-pkg/coral_usb_ros, it publishes RectArray and ClassificationResult at same time.
I want some opinion.
|
Sorry for late. I left single comment, but overall lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables visual grounding using GroundingDINO.
How to use
After build the Image with bellow
You need to specify the port, etc. according to the situation, but you can launch docker as follows
Launch the ros node as follows