Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for oidc auth in k8s client #1

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

richerve
Copy link

@richerve richerve commented Dec 8, 2023

mapkubeapis fails when connecting to a cluster that uses oidc as auth method.

This change is essentially the implementation of helm#115

Withouh this a call to the cmd fails with:

Error: failed to get release 'kube' latest version: query: failed to query with labels: no Auth Provider found for name "oidc"

Verification

make build
./bin/mapkubeapis -n <namespace> <release> --dry-run

Copy link

@yuzhouliu9 yuzhouliu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

> ./bin/mapkubeapis --namespace corps papercuts-cron --dry-run
2023/12/08 09:47:49 NOTE: This is in dry-run mode, the following actions will not be executed.
2023/12/08 09:47:49 Run without --dry-run to take the actions described below:
2023/12/08 09:47:49
2023/12/08 09:47:49 Release 'papercuts-cron' will be checked for deprecated or removed Kubernetes APIs and will be updated if necessary to supported API versions.
2023/12/08 09:47:49 Get release 'papercuts-cron' latest version.
2023/12/08 09:47:49 Check release 'papercuts-cron' for deprecated or removed APIs...
2023/12/08 09:47:49 Found 1 instances of deprecated or removed Kubernetes API:
"apiVersion: batch/v1beta1
kind: CronJob
"
Supported API equivalent:
"apiVersion: batch/v1
kind: CronJob
"
2023/12/08 09:47:49 Finished checking release 'papercuts-cron' for deprecated or removed APIs.
2023/12/08 09:47:49 Deprecated or removed APIs exist, for release: papercuts-cron.
2023/12/08 09:47:49 Map of release 'papercuts-cron' deprecated or removed APIs to supported versions, completed successfully.

@richerve richerve removed the request for review from whwalter December 8, 2023 15:06
@richerve richerve merged commit 7431bf6 into main Dec 8, 2023
@richerve richerve deleted the feature/oidc-support branch December 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants