Added test to verify package modules are accessible as symbols #422
Conversation
|
Please make sure CI passes before requesting reviews. Unless you need help with something. Thank you ❤️ |
octonawish-akcodes
had a problem deploying
to
staging
GitHub Actions
Failure
|
@spbnick Have a look now? |
There was a problem hiding this comment.
Nice start, Abhishek. I have a few questions inline, but the main thing is that this is not recursive and only checks two levels. You can make this recursive, if you define a function inside the test, which accepts a package, checks its contents, and calls itself on each package inside the supplied package. Then you can call this function (let's call it check_package for this example) from the test function like this: check_package(kcidb).
|
Also, it's strange that this doesn't fail for any of the packages you managed to check here 🤔 |
octonawish-akcodes
had a problem deploying
to
staging
GitHub Actions
Failure
There was a problem hiding this comment.
Thank you, @octonawish-akcodes! This is pretty good already. I left you a couple requests inline.
Otherwise, have you tested this? E.g. by removing a symbol for a submodule, or adding a (dummy) submodule without adding the symbol?
test_kcidb.py
Outdated
| module_fullname = f"{package.__name__}.{module_name}" | ||
| module = importlib.import_module(module_fullname) | ||
| assert hasattr(package, module_name) | ||
| assert isinstance(getattr(package, module_name), type(module)) |
There was a problem hiding this comment.
Could you check that the actual symbol is the module? E.g. like this:
assert getattr(package, module_name, None) is moduleThis would replace both of your assertions.
It would help if you added a comprehensive message for the assertion failure something along the lines of "Package X is missing the symbol for submodule Y".
There was a problem hiding this comment.
I tried everything but its passing on every stage sir
There was a problem hiding this comment.
Could you figure out why, and what the solution should be? This test would be useless otherwise.
Signed-off-by: Abhishek Kumar <[email protected]>
octonawish-akcodes
had a problem deploying
to
staging
GitHub Actions
Failure
This PR added a test to verify package modules are accessible as symbols in the kcidb directory.
This PR closes #404
@spbnick need reviews