Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for installing custom root ca certificates #1428

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

kosamson
Copy link
Contributor

Adds a documentation page under the "Advanced" section outlining how to install custom root certificates into a container built using ko.

Discussed initially in #1424 and suggested by @jeffmendoza

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can use: https://github.com/chainguard-dev/incert after you build your image with ko

@kosamson
Copy link
Contributor Author

also can use: https://github.com/chainguard-dev/incert after you build your image with ko

This is really useful, I've never heard about this before. Let me add a section on using this in the new documentation page. This makes building a CI workflow to add the certificates automatically seem really easy.

@kosamson
Copy link
Contributor Author

added a section on using incert (thank you for the suggestion @cpanato).

@kosamson kosamson requested a review from cpanato October 19, 2024 01:19
cpanato
cpanato previously approved these changes Oct 23, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

will wait for @imjasonh for more 👀

@cpanato cpanato requested a review from imjasonh October 23, 2024 07:15
adds a documentation page under the advanced section outlining how to
install custom root certificates into a container built using ko
@kosamson
Copy link
Contributor Author

rebased my branch to main. i haven't done a github PR in a while so not sure if I messed up the review workflow. if I need to change something pls let me know and I'll fix it.

Copy link
Contributor

@jeffmendoza jeffmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

@imjasonh imjasonh enabled auto-merge (rebase) October 30, 2024 17:20
@imjasonh imjasonh merged commit d077603 into ko-build:main Oct 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants