-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation for installing custom root ca certificates #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can use: https://github.com/chainguard-dev/incert after you build your image with ko
This is really useful, I've never heard about this before. Let me add a section on using this in the new documentation page. This makes building a CI workflow to add the certificates automatically seem really easy. |
added a section on using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
will wait for @imjasonh for more 👀
adds a documentation page under the advanced section outlining how to install custom root certificates into a container built using ko
dc2aa83
to
a57003d
Compare
rebased my branch to main. i haven't done a github PR in a while so not sure if I messed up the review workflow. if I need to change something pls let me know and I'll fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this up!
Adds a documentation page under the "Advanced" section outlining how to install custom root certificates into a container built using
ko
.Discussed initially in #1424 and suggested by @jeffmendoza