You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes ko build to interpret an importpath string that ends in
"/..." by running go list and parsing its output to find package mains matched by that wildcard.
Since ko build already supports passing multiple paths, this
additively collects uniq matched importpaths, so this works, and
produces three images for the three package mains in this repo:
ko build ./... ./cmd/... ./
Matched paths are still checked if they're package main, so this
doesn't work:
ko build ./... ./pkg/build
(because the explicit pkg/build isn't package main)
This also doesn't work, because the wildcard importpath doesn't match any package mains:
ko build ./pkg/...
This does work, because the set of wildcard importpaths taken together matches at least one package main:
This changes `ko build` to interpret an importpath string that ends in
"/..." by running `go list` and parsing its output to find `package
main`s matched by that wildcard.
Since `ko build` already supports passing multiple paths, this
additively collects uniq matched importpaths, so this works, and
produces three images for the three `package main`s in this repo:
```
ko build ./... ./cmd/... ./
```
Matched paths are still checked if they're `package main`, so this
doesn't work:
```
ko build ./... ./pkg/build
```
(because `pkg/build` isn't `package main`)
Integration tests fail while I'm using packages.Load instead of shelling out to go list -- I'll either figure it out, or just switch to go list until I figure it out.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
ko buildto interpret an importpath string that ends in"/..." by running
go listand parsing its output to findpackage mains matched by that wildcard.Since
ko buildalready supports passing multiple paths, thisadditively collects uniq matched importpaths, so this works, and
produces three images for the three
package mains in this repo:Matched paths are still checked if they're
package main, so thisdoesn't work:
(because the explicit
pkg/buildisn'tpackage main)This also doesn't work, because the wildcard importpath doesn't match any
package mains:This does work, because the set of wildcard importpaths taken together matches at least one
package main:Fixes #643
Fixes #273