Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --all option to build command #908

Closed
wants to merge 1 commit into from
Closed

Add --all option to build command #908

wants to merge 1 commit into from

Conversation

carlpett
Copy link

This PR adds an --all flag to the build command, allowing to build all targets specified in .ko.yaml.

Fixes #643

@carlpett
Add --all option to build command
8045008 
Signed-off-by: Calle Pettersson <[email protected]>
@carlpett
Copy link
Author

Hm, it seems I was a bit too quick on this. BuildOptions is used in pretty much all commands. I'm not sure --all makes sense in many of those contexts, though.
Would it be best to add a new flag set specifically for build that isn't reused between commands, or is there another way forward here?

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idea: build all images defined in .ko.yaml
1 participant
@carlpett