-
Notifications
You must be signed in to change notification settings - Fork 890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom refdb backend support #1739
Open
sterlind
wants to merge
26
commits into
libgit2:master
Choose a base branch
from
sterlind:refdb-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like AppVeyor failed with some build machine issue:
Could a maintainer please rerun the check? |
…lic) return IntPtr. This is safe, since libgit2 disposes te handles after consuming them, and allocating the handles is the last thing the callbacks do, so no exceptions can cause leaks.
This reverts commit 529b618.
is there any hope this pr will be merged? |
@bording Is it possible for you to look at this? We utilitize the features this PR adds as well and have to maintain our own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rewrite of zoxiv's refdb backend PR #1482 (their code here), since that targeted an ancient libgit2 with substantial API changes since then.
Changes due to libgit2:
foreach
andforeach_glob
were replaced with a newiterator
callback in libgit2. Replaced them with a method that returnsIEnumerable<ReferenceData>
.Other changes:
RefdbBackendExceptions
to signal errors, which simplifies the glue and lets native libgit2 error codes be returned.