feat: Vaults #874
Draft
feat: Vaults #874
+9,109
−3,021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add vaults reporting to accounting
Vault fees and oracle reports refactoring
Vault factory
…56k1-4.0.4 build(deps): bump secp256k1 from 4.0.3 to 4.0.4
fix: return value and stuff
Co-authored-by: Logachev Nikita <[email protected]>
feat: add separate step for vaults deployment
TheDZhon
reviewed
Nov 27, 2024
There was a problem hiding this comment.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: 6286561 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Eugene Mamin <[email protected]>
TheDZhon
reviewed
Nov 28, 2024
| @@ -0,0 +1,482 @@ | |||
| // SPDX-FileCopyrightText: 2023 Lido <[email protected]> | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 Lido <[email protected]> | |
| // SPDX-FileCopyrightText: 2024 Lido <[email protected]> |
Comment on lines
+9
to
+16
| import {ILidoLocator} from "../common/interfaces/ILidoLocator.sol"; | ||
| import {IBurner} from "../common/interfaces/IBurner.sol"; | ||
| import {IPostTokenRebaseReceiver} from "./interfaces/IPostTokenRebaseReceiver.sol"; | ||
| import {IStakingRouter} from "./interfaces/IStakingRouter.sol"; | ||
| import {IOracleReportSanityChecker} from "./interfaces/IOracleReportSanityChecker.sol"; | ||
| import {IWithdrawalQueue} from "./interfaces/IWithdrawalQueue.sol"; | ||
| import {ILido} from "./interfaces/ILido.sol"; | ||
| import {ReportValues} from "contracts/common/interfaces/ReportValues.sol"; |
There was a problem hiding this comment.
Why not embedded in the file here? (Lido contract has embedded ones)
There was a problem hiding this comment.
For the sake of consistency: let's use one way or another
|
|
||
| /// @title Lido Accounting contract | ||
| /// @author folkyatina | ||
| /// @notice contract is responsible for handling oracle reports |
There was a problem hiding this comment.
Suggested change
| /// @notice contract is responsible for handling oracle reports | |
| /// @notice contract is responsible for handling accounting oracle reports |
| /// @notice contract is responsible for handling oracle reports | ||
| /// calculating all the state changes that is required to apply the report | ||
| /// and distributing calculated values to relevant parts of the protocol | ||
| contract Accounting is VaultHub { |
There was a problem hiding this comment.
surprising to see that Accounting is VaultHub
| ReportValues memory _report, | ||
| PreReportState memory _pre, | ||
| CalculatedValues memory _update, | ||
| uint256 _simulatedShareRate |
There was a problem hiding this comment.
Suggested change
| uint256 _simulatedShareRate | |
| uint256 _withdrawalShareRate |
let's unify naming
| } | ||
|
|
||
| // Distribute protocol fee (treasury & node operators) | ||
| if (_update.sharesToMintAsFees > 0) { |
There was a problem hiding this comment.
this name might be misleading, should be named smth 'sharesToMintAsLidoV2ProtocolFees'
|
|
||
| _updateVaults( | ||
| _report.vaultValues, | ||
| _report.netCashFlows, |
| _update.vaultsTreasuryFeeShares | ||
| ); | ||
|
|
||
| _notifyObserver(_contracts.postTokenRebaseReceiver, _report, _pre, _update); |
There was a problem hiding this comment.
Suggested change
| _notifyObserver(_contracts.postTokenRebaseReceiver, _report, _pre, _update); | |
| _notifyRebaseObserver(_contracts.postTokenRebaseReceiver, _report, _pre, _update); |
| } | ||
| } | ||
|
|
||
| /// @dev mints treasury rewards |
There was a problem hiding this comment.
only for Lido V2 protocol fee though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 🚧 Under construction 🚧 ❗
Staking Vaults
New way of isolated staking, through separate vaults, with optional stETH liquidity